[vlc-devel] [RESEND] [PATCH] Qt: Enable Stop Time in media convert dialog

[Rajeesh K V]

Hi Filip,

On Thu, Oct 27, 2016 at 3:34 PM, Filip Roséen wrote:
> This could be written a lot simpler by updating the format-string so 
> that you are generating the string-representation of a floating-point 
> with the value of QTime::msecsTo divided by 1000.
> 
> Remember that you can specify the number of decimals, as well as 
> padding, directly in the format-string; there’s no explicit need to 
> do this by hand.
> 
> I reckon you are basing your implementation on what is done for 
> :start-time, so if you fix your implementation - you could refactor 
> :start-time at the same time.
> 
Thanks for the review comments. Please find the revised patch:

Author: Rajeesh K V <rajeeshknambiar at gmail.com>
Date:   Tue Aug 16 10:38:46 2016 +0530

    Qt: Enable Stop Time in media convert dialog

    Changes in V2: Revise QTime formatting as suggested by Filip Roséen

    Convert/Save dialog has had option to specify 'start time' but
    no option for setting 'stop time' in the interface. The backend
    'stop-time' option was already present. This patch simply adds
    and enables the edit widget for end time in Qt interface.

diff --git a/modules/gui/qt/dialogs/open.cpp 
b/modules/gui/qt/dialogs/open.cpp
index 224cfa5..86f5d00 100644
--- a/modules/gui/qt/dialogs/open.cpp
+++ b/modules/gui/qt/dialogs/open.cpp
@@ -156,6 +156,7 @@ OpenDialog::OpenDialog( QWidget *parent,
     CONNECT( ui.slaveText, textChanged( const QString& ), this, 
updateMRL() );
     CONNECT( ui.cacheSpinBox, valueChanged( int ), this, updateMRL() );
     CONNECT( ui.startTimeTimeEdit, timeChanged ( const QTime& ), this, 
updateMRL() );
+    CONNECT( ui.stopTimeTimeEdit, timeChanged ( const QTime& ), this, 
updateMRL() );
     BUTTONACT( ui.advancedCheckBox, toggleAdvancedPanel() );
     BUTTONACT( ui.slaveBrowseButton, browseInputSlave() );

@@ -179,6 +180,7 @@ OpenDialog::OpenDialog( QWidget *parent,

     /* enforce section due to .ui bug */
     ui.startTimeTimeEdit->setCurrentSection( 
QDateTimeEdit::SecondSection );
+    ui.stopTimeTimeEdit->setCurrentSection( 
QDateTimeEdit::SecondSection );

     setMinimumSize( sizeHint() );
     setMaximumWidth( 900 );
@@ -436,12 +438,12 @@ void OpenDialog::updateMRL() {
     mrl += QString( " :%1=%2" ).arg( storedMethod ).
                                 arg( ui.cacheSpinBox->value() );
     if( ui.startTimeTimeEdit->time() != 
ui.startTimeTimeEdit->minimumTime() ) {
-        mrl += QString( " :start-time=%1.%2" )
-                .arg( QString::number(
-                    ui.startTimeTimeEdit->minimumTime().secsTo(
-                        ui.startTimeTimeEdit->time()
-                ) ) )
-               .arg( ui.startTimeTimeEdit->time().msec(), 3, 10, 
QChar('0') );
+        mrl += " :start-time=" + 
QString::number(static_cast<double>(ui.startTimeTimeEdit->
+                                
minimumTime().msecsTo(ui.startTimeTimeEdit->time() ) )/1000.0,'f',3);
+    }
+    if( ui.stopTimeTimeEdit->time() > ui.startTimeTimeEdit->time() ) {
+        mrl += " :stop-time=" + 
QString::number(static_cast<double>(ui.stopTimeTimeEdit->
+                                
minimumTime().msecsTo(ui.stopTimeTimeEdit->time() ) )/1000.0,'f',3);
     }
     ui.advancedLineInput->setText( mrl );
     ui.mrlLine->setText( itemsMRL.join( " " ) );
diff --git a/modules/gui/qt/ui/open.ui b/modules/gui/qt/ui/open.ui
index ea510db..05d8193 100644
--- a/modules/gui/qt/ui/open.ui
+++ b/modules/gui/qt/ui/open.ui
@@ -169,6 +169,19 @@
         </property>
        </widget>
       </item>
+      <item row="1" column="3">
+       <widget class="QLabel" name="label_3">
+        <property name="text">
+         <string>Stop Time</string>
+        </property>
+        <property name="alignment">
+         <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+        </property>
+        <property name="buddy">
+         <cstring>stopTimeTimeEdit</cstring>
+        </property>
+       </widget>
+      </item>
       <item row="8" column="0">
        <widget class="QLabel" name="label">
         <property name="text">
@@ -241,6 +254,25 @@
         </property>
        </widget>
       </item>
+      <item row="1" column="4" colspan="2">
+       <widget class="QTimeEdit" name="stopTimeTimeEdit">
+        <property name="toolTip">
+         <string>Change the stop time for the media</string>
+        </property>
+        <property name="alignment">
+         <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+        </property>
+        <property name="currentSection">
+         <enum>QDateTimeEdit::HourSection</enum>
+        </property>
+        <property name="displayFormat">
+         <string>HH'H':mm'm':ss's'.zzz</string>
+        </property>
+        <property name="timeSpec">
+         <enum>Qt::LocalTime</enum>
+        </property>
+       </widget>
+      </item>
       <item row="4" column="0" colspan="6">
        <widget class="QCheckBox" name="slaveCheckbox">
         <property name="text">
@@ -271,6 +303,7 @@
   <tabstop>advancedCheckBox</tabstop>
   <tabstop>cacheSpinBox</tabstop>
   <tabstop>startTimeTimeEdit</tabstop>
+  <tabstop>stopTimeTimeEdit</tabstop>
   <tabstop>slaveCheckbox</tabstop>
   <tabstop>slaveText</tabstop>
   <tabstop>slaveBrowseButton</tabstop>