[vlc-devel] [PATCH 1/2] demux/subtitles: add new implementation for line-peeking

[Rémi Denis-Courmont]

Le maanantaina 7. marraskuuta 2016, 18.56.01 EET Filip Roséen a écrit :
> Hi Rémi,
> 
> On 2016-11-07 19:47, Rémi Denis-Courmont wrote:
> > No, you can´t: The offset needs to be stored somewhere if you peek more
> > than one line. Indeed, the current code has it, your patch and it, and my
> > wrapper has it.
> 
> I would not have said that it was possible if I did not see ways of
> implementing it.
> 
> One, of actually quite a few, ways of implementing this would be to
> utilize the `block_t::p_next` of `stream_priv_t::p_peek` in order to
> store the associated state required.

Yes. You can always make even worse and uglyier hacks.

But no thanks.

-- 
Rémi Denis-Courmont
http://www.remlab.net/