[vlc-devel] [RESEND] [PATCH] Qt: Enable Stop Time in media convert dialog

Rajeesh K V rajeeshknambiar at gmail.com
Tue Nov 8 04:37:42 CET 2016

Hi Filip,

On Mon, Nov 7, 2016 at 9:06 PM, Filip Roséen <filip at atch.se> wrote:
> Hi Rajeesh,
> It is not advisable to simply copy+paste a patch generated by git 
> format-patch into the mail-client of choice without making sure that 
> it does not add additional formatting to the message.
> The patch you have submitted has been a victim of automatic, as I 
> assume that you did not do this yourself, line-wrapping. Something 
> which easily is recognized by looking at it through patchwork:
> https://patches.videolan.org/patch/14962/
> Please resubmit a correctly formatted patch, and if you want to do it 
> as a reply in this thread; simply state your business in a regular 
> message, and then add the .patch as an attachment.
The email client did the line wrapping (used Geary as gmail web 
interface is known to wrap lines, but that didn't help either).
Addressing your review comments, attached the updated patch. I checked 
the indentation in 4 different editors/apps, hopefully it is correct.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-convert-enable-stop-time-v3.patch
Type: text/x-patch
Size: 4540 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161108/df58bcb6/attachment.bin>

More information about the vlc-devel mailing list