[vlc-devel] [RESEND] [PATCH] Qt: Enable Stop Time in media convert dialog

Rajeesh K V rajeeshknambiar at gmail.com
Tue Nov 8 13:33:44 CET 2016

> Other than the really long line in open.cpp:TimeTomSecs, and perhaps the
> name of the function (TimeToMilliseconds is easier to read), it looks
> alright.

Changed the function and parameter names, it is slightly shorter now.

> Is there a ticket associated with this feature? If so; include “Fixes #123”
> in the commit message (where 123 is the ticket-id).

I couldn't find one searching in trac.videolan.org

> Given that this is a new feature, you could update NEWS to include a line
> under Qt interface saying that it is now possible to specify stop-time in
> the relevant dialog.


> Well done; LGTM!

Many thanks for your review, Filip!

Attached the patch. Please commit.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-Enable-Stop-Time-in-media-convert-dialog.patch
Type: text/x-patch
Size: 5247 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161108/238977e2/attachment.bin>

More information about the vlc-devel mailing list