[vlc-devel] [PATCH 00/16] VR/360 navigation, new set

Rémi Denis-Courmont remi at remlab.net
Wed Nov 9 19:40:40 CET 2016


Le keskiviikkona 9. marraskuuta 2016, 19.29.48 EET Thomas Guillem a écrit :
> On Wed, Nov 9, 2016, at 19:21, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 9. marraskuuta 2016, 19.02.37 EET Thomas Guillem a écrit
> > 
> > > On Wed, Nov 9, 2016, at 18:58, Rémi Denis-Courmont wrote:
> > > > Le keskiviikkona 9. marraskuuta 2016, 18.32.54 EET Thomas Guillem a
> > > > écrit
> > > > 
> > > > > Hello, we propose a new set of patches for VR/360 navigation.
> > > > > 
> > > > > The first commit changed quite a lot:
> > > > >  - vout_SetViewpoint() is renamed to vout_UpdateViewpoint(). This
> > > > >  new
> > > > > 
> > > > > function allow now to increment a viewpoint to the one that is
> > > > > currently
> > > > > used by the vout.
> > > > 
> > > > That seems like a step backward to me. Functions for incremental
> > > > changes
> > > > instead of proper setters - we have been there done that already
> > > > several
> > > 
> > > There is also a setter.
> > 
> > I don´t see the point in having both. In practice, there either only be
> > one
> > user so that atomicity and arbitration are useless, or there will be an
> > upper
> > layer to mediate (presumably the input manager), or both.
> 
> With libvlc, there will be only one user, OK.
> 
> For Desktop, there can be more: the vout that handle the mouse events
> and the hotkeys interface that control the arrow keys.

The vout does not handle mouse events. It generates them and passes them 
upward through the filters, and then the core passes them to the input.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list