[vlc-devel] [PATCH 2/2] input: add INPUT_SET_VIEWPOINT

[Rémi Denis-Courmont]

Le torstaina 10. marraskuuta 2016, 20.02.21 EET Jean-Baptiste Kempf a écrit :
> Hello,
> 
> On Thu, 10 Nov 2016, at 19:56, Rémi Denis-Courmont wrote:
> > You could use separate controls instead of a boolean. Or even a ditch the
> > control and make a function with a separate boolean parameter.
> 
> I won't comment on that part.
> 
> > But then again, doing this at input thread level will prevent cross-input
> > persistence, which is likely desirable. So that seems too "low level" to
> > me.
> 
> So far, from what I've seen from 360 videos (and discussed with 360
> creators), and the mess those video are, I'd argue we don't want
> cross-input persistence for the viewpoint.
> In the future, maybe; but for now, I'd argue we need to go back to the
> initial viewpoint values set inside the metadata.

Then the external interface is fine.

However, I strongly suspect that vout change / ES change within an input 
should maintain the angle - consider change of video quality... And I don´t 
understand where the initial per-vout value comes from.

-- 
Rémi Denis-Courmont
https://www.remlab.net/