[vlc-devel] [vlc-commits] macosx: Some type-annotated array fixes for Xcode 7

[David Fuhrmann]

> Am 15.11.2016 um 00:16 schrieb Marvin Scholz <git at videolan.org>:
> 
> vlc | branch: master | Marvin Scholz <epirat07 at gmail.com> | Tue Nov 15 00:15:42 2016 +0100| [dcee486154ec8bdad0f68a4d023dfa2a3b17981d] | committer: Marvin Scholz
> 
> macosx: Some type-annotated array fixes for Xcode 7
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=dcee486154ec8bdad0f68a4d023dfa2a3b17981d
> ---
> 
> modules/gui/macosx/VLCRendererDialog.h    | 4 ++++
> modules/gui/macosx/VLCRendererDialog.m    | 4 ++++
> modules/gui/macosx/VLCRendererDiscovery.h | 4 ++++
> 3 files changed, 12 insertions(+)
> 
> diff --git a/modules/gui/macosx/VLCRendererDialog.h b/modules/gui/macosx/VLCRendererDialog.h
> index 4999294..1203610 100644
> --- a/modules/gui/macosx/VLCRendererDialog.h
> +++ b/modules/gui/macosx/VLCRendererDialog.h
> @@ -28,7 +28,11 @@
> 
> @interface VLCRendererDialog : NSWindowController <VLCRendererDiscoveryDelegate, NSWindowDelegate>
> 
> +#ifdef MAC_OS_X_VERSION_10_11
> @property NSMutableArray<VLCRendererItem*> *rendererItems;
> +#else
> + at property NSMutableArray *rendererItems;
> +#endif

Hi,

Do we really want to ifdef all NS(Mutable)Array instances in the future? I feel like this might be a bit overcomplicated.

What are the downsides if we just stay with the old syntax?

Best regards,
David