[vlc-devel] [PATCH] demux: mp4: support 360° v2 spatial metadata

[Steve Lhomme]

On Wed, Nov 16, 2016 at 6:16 PM, Francois Cartegnie <fcvlcdev at free.fr> wrote:
> Le 16/11/2016 à 17:17, Steve Lhomme a écrit :
>> as found here https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md
>
>> +        switch( BOXDATA(p_st3d)->i_stereo_mode )
>> +        {
>> +        case ST3D_MONOSCOPIC:
>> +            p_track->fmt.video.multiview_mode = MULTIVIEW_2D;
>> +            break;
>> +        case ST3D_STEREOSCOPIC_TOP_BOTTOM:
>> +            p_track->fmt.video.multiview_mode = MULTIVIEW_STEREO_TB;
>> +            break;
>> +        case ST3D_STEREOSCOPIC_LEFT_RIGHT:
>> +            p_track->fmt.video.multiview_mode = MULTIVIEW_STEREO_SBS;
>> +            break;
>> +        }
>
> Seems correct, but compiler will bug about missing default case.

We should probably warn about an unknown value and use flat.

> Unsure if we need to handle 'mandatory' atom cases.
>
> Francois
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel