[vlc-devel] [PATCH 2/2] input/input: input_SubtitleFile2Uri: handle URIs

Filip Roséen filip at atch.se
Fri Nov 18 05:13:22 CET 2016

Hi myself,

On 2016-11-18 03:59, Filip Roséen wrote:

> The previous implementation assumed that the data passed was a local
> path, which limited the usability of the function (effectively
> preventing subtitles passed as URIs from being added).
> These changes allow both local paths and URIs to be handled by the
> function, effectively making sure that file://... are subject to
> transformation (while leaving other entities untouched).
> refs #17657

I hope you realize that you just submitted the *work-in-progress*
patch instead of what you actually wanted to submit (since you forgot
to `git commit --amend`)?

As I am being the responsible (awake) second half, please see the
attached patch for one that is actually correct (and not just a

Best Regards,\
Me, Myself, and I.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161118/265ff1b4/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-input-input-input_SubtitleFile2Uri-handle-URIs.patch
Type: text/x-diff
Size: 3093 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161118/265ff1b4/attachment.patch>

More information about the vlc-devel mailing list