[vlc-devel] [PATCH] osx_notification: Remove "item-change" callback

Filip Roséen filip at atch.se
Fri Nov 18 10:10:03 CET 2016


Hi Marvin,

On 2016-11-17 22:53, Marvin Scholz wrote:

> Notify as soon as the current input item is changed,
> as it is not a good idea to rely on an item-change
> eventually happening later.
> This will result in some items that are added and played
> immediately lacking metadata in their notifications but
> this seems like an acceptable edge case.
> ---
>  modules/notify/osx_notifications.m | 122 ++++++++++---------------------------
>  1 file changed, 33 insertions(+), 89 deletions(-)

*LGTM*.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161118/1923714f/attachment.html>


More information about the vlc-devel mailing list