[vlc-devel] [PATCH 2/2] input/input: input_SubtitleFile2Uri: handle URIs

Filip Roséen filip at atch.se
Fri Nov 18 11:01:09 CET 2016

  Resending this message due to weird `Reply-To` on the email which this
  one is (now properly) a reply to.

Hi Rémi,

On 2016-11-18 09:52, Rémi Denis-Courmont wrote:

> The function name implies path as input so nack. Maybe rename the
> function [.]

I see no inherent problem with the *function-name*, a *file* is a
*file* no matter if it is being referred to by an *URI* or relative

But the function name could/should be changed to something else for
different reasons. It has never reflected the intent of the function
(which is to "redirect" one subtitle-extension to another, if
the latter is present).

> [...] AFAIR, wz already have support for adding slaves as URI.

It's about support for adding slaves as URI given the relevant
code-path, not overall.

Yes, we do have support for adding slaves through `INPUT_ADD_SLAVE`
with an explicit type. That approach does however *not* the
`subtitles_Filter` as `INPUT_ADD_SLAVE` (meaning that code that
conditionally want to add something as a subtitle-slave will have to
reimplement that functionality).

Merging `INTPUT_ADD_SLAVE` and `INPUT_ADD_SUBTITLE` could be a
possibility, but the changes will be more drastic.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161118/9cdfe951/attachment.html>

More information about the vlc-devel mailing list