[vlc-devel] [PATCH 2/2] core: don't reserve decoder pictures for filtering in direct renderering

[Steve Lhomme]

On Sat, Nov 26, 2016 at 9:45 AM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> And how do we ensure that there are enough pictures for filters then?

Is there any filter when using direct rendering on other platforms ? I
know there isn't on Windows. Maybe we could ifdef _WIN32 that code if
that's the case.

> Le samedi 26 novembre 2016, 06:17:24 Steve Lhomme a écrit :
>> From: Steve Lhomme <slhomme at matroska.org>
>>
>> ---
>>  src/video_output/vout_wrapper.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/video_output/vout_wrapper.c
>> b/src/video_output/vout_wrapper.c index 10c615e..cc9068a 100644
>> --- a/src/video_output/vout_wrapper.c
>> +++ b/src/video_output/vout_wrapper.c
>> @@ -124,7 +124,7 @@ int vout_InitWrapper(vout_thread_t *vout)
>>
>>      sys->display.use_dr = !vout_IsDisplayFiltered(vd);
>>      const bool allow_dr = !vd->info.has_pictures_invalid &&
>> !vd->info.is_slow && sys->display.use_dr; -    const unsigned
>> private_picture  = 4; /* XXX 3 for filter, 1 for SPU */ +    unsigned
>> private_picture  = 4; /* XXX 3 for filter, 1 for SPU */ const unsigned
>> decoder_picture  = 1 + sys->dpb_size;
>>      const unsigned kept_picture     = 1; /* last displayed picture */
>>      const unsigned reserved_picture = DISPLAY_PICTURE_COUNT +
>> @@ -147,6 +147,7 @@ int vout_InitWrapper(vout_thread_t *vout)
>>          sys->dpb_size     = picture_pool_GetSize(display_pool) -
>> reserved_picture; sys->decoder_pool = display_pool;
>>          sys->display_pool = display_pool;
>> +             private_picture = 1; /* there won't be any filter, just SPU */
>
> News to me.
>
>>      } else if (!sys->decoder_pool) {
>>          sys->decoder_pool =
>>              picture_pool_NewFromFormat(&source,
>
> --
> Rémi Denis-Courmont
> http://www.remlab.net/
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel