[vlc-devel] [PATCHv2 2/3] deinterlace: x86: add external asm emms function

[Rémi Denis-Courmont]

Le sunnuntaina 27. marraskuuta 2016, 22.24.20 EET Janne Grunau a écrit :
> On 2016-11-27 23:17:22 +0200, Rémi Denis-Courmont wrote:
> > Le sunnuntaina 27. marraskuuta 2016, 21.55.44 EET Janne Grunau a écrit :
> > > On 2016-11-27 22:32:12 +0200, Rémi Denis-Courmont wrote:
> > > > Same problems as previous version, AFAICT.
> > > 
> > > which are?
> > > 
> > > emms is instruction/function without arguments and return value but side
> > > effects. So it will be used exactly in the it is supposed to be used.
> > > 
> > > If you don't like the way the yasm asm source are handled please offer
> > > an alternative and explain why it should be handled differently than the
> > > arm asm.
> > 
> > The ARM assembler code does not rely on unwarranted C compiler behaviour
> > AFAICT.
> 
> neither does the x86 yasm asm

AFAICT, if the calling code does not rely on UB, then this function should 
have no useful effects. So something is very wrong here, even if this patch 
proper does not strictly speaking rely on UB.

-- 
Rémi Denis-Courmont
https://www.remlab.net/