[vlc-devel] [PATCH] vaapi: add support for HEVC decoding

[Rémi Denis-Courmont]

On November 28, 2016 12:48:24 PM GMT+02:00, Mathieu Velten <matmaul at gmail.com> wrote:
>Le ven. 25 nov. 2016 à 20:57, Rémi Denis-Courmont <remi at remlab.net> a
>écrit :
>
>> Le perjantaina 25. marraskuuta 2016, 16.14.21 EET Mathieu Velten a
>écrit :
>> > ---
>> >  modules/codec/avcodec/vaapi.c | 9 ++++++++-
>> >  1 file changed, 8 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/modules/codec/avcodec/vaapi.c
>> b/modules/codec/avcodec/vaapi.c
>> > index 8671139..b58f69a 100644
>> > --- a/modules/codec/avcodec/vaapi.c
>> > +++ b/modules/codec/avcodec/vaapi.c
>> > @@ -317,7 +317,14 @@ static int Create( vlc_va_t *va,
>AVCodecContext
>> *ctx,
>> > enum PixelFormat pix_fmt, case AV_CODEC_ID_H264:
>> >          i_profile = VAProfileH264High;
>> >          count = 18;
>> > -        break;;
>> > +        break;
>> > +    case AV_CODEC_ID_HEVC:
>> > +        if (ctx->profile == FF_PROFILE_HEVC_MAIN_10)
>> > +            i_profile = VAProfileHEVCMain10;
>> > +        else
>> > +            i_profile = VAProfileHEVCMain;
>>
>> This looks rather dubious.
>>
>
>Can you elaborate ? It works for both profiles (tested).
>
>
>> > +        count = 18;
>> > +        break;
>> >      default:
>> >          return VLC_EGENERIC;
>> >      }
>>
>>
>> --
>> Rémi Denis-Courmont
>> https://www.remlab.net/
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>
>
>------------------------------------------------------------------------
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

Stating the obvious but there are no "both" profiles. HEVC has more than two of them.
-- 
Rémi Denis-Courmont
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161128/e7a64474/attachment.html>