[vlc-devel] [PATCH 2/2] core: don't reserve decoder pictures for filtering in direct renderering

[Rémi Denis-Courmont]

Le maanantaina 28. marraskuuta 2016, 16.03.15 EET Steve Lhomme a écrit :
> On Mon, Nov 28, 2016 at 3:29 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > On November 28, 2016 2:27:10 PM GMT+02:00, Steve Lhomme <robux4 at gmail.com> 
wrote:
> >>It seems that vdpau has some filters that can handle
> >>VLC_CODEC_VDPAU_VIDEO_XXX as input and output. There are actually 4 of
> >>them so if you want to use all of them at once it won't work either.
> >>
> >>This magic 3 number is odd. I understand it's better to allocate
> >>things once to avoid failing later. But maybe the filter shouldn't
> >>peek in a static reserved pool or we want to ensure a filter always
> >>have something to process into, we should at least fix the number of
> >>reserved pictures once we know how many filters will be used.
> >>
> >>On Sun, Nov 27, 2016 at 4:39 PM, Steve Lhomme <robux4 at gmail.com> wrote:
> >>> On Sat, Nov 26, 2016 at 10:32 AM, Rémi Denis-Courmont
> >>
> >><remi at remlab.net> wrote:
> >>>> Le samedi 26 novembre 2016, 09:56:00 Steve Lhomme a écrit :
> >>>>> On Sat, Nov 26, 2016 at 9:45 AM, Rémi Denis-Courmont
> >>
> >><remi at remlab.net>
> >>
> >>>> wrote:
> >>>>> > And how do we ensure that there are enough pictures for filters
> >>
> >>then?
> >>
> >>>>> Is there any filter when using direct rendering on other platforms
> >>
> >>?
> >>
> >>>> And what do you mean by that? To my knowledge, all platforms support
> >>
> >>filters
> >>
> >>>> with DR.
> >>> 
> >>> Maybe I should be more precise: no filter with direct rendering
> >>> output. There are inputs on Windows as well possible to convert
> >>
> >>opaque
> >>
> >>> to non-opaque. But no filter that will output an opaque picture, that
> >>> would need some picture from the vout pool.
> >>> 
> >>>> --
> >>>> Rémi Denis-Courmont
> >>>> http://www.remlab.net/
> >>>> _______________________________________________
> >>>> vlc-devel mailing list
> >>>> To unsubscribe or modify your subscription options:
> >>>> https://mailman.videolan.org/listinfo/vlc-devel
> >>
> >>_______________________________________________
> >>vlc-devel mailing list
> >>To unsubscribe or modify your subscription options:
> >>https://mailman.videolan.org/listinfo/vlc-devel
> >>
> > Most filters don't need extra refs, and as long as video filters don't get
> > their own VLC object structure type, there is no way for them to convey
> > that bit of info.
> So what's this "3" value for ? Can we get rid of it ? Reduce it ?
> 
> > VDPAU does not do DR that I'd know so I don't understand what you are
> > saying
> OK so there doesn't seem to be any filter used when using direct
> rendering,

Of course there can be filters in DR. This patch is completely wrong and I´ll 
leave it at that.

-- 
Rémi Denis-Courmont
https://www.remlab.net/