[vlc-devel] [RFC 06/10] input/demux: prepare input_DemuxNew for future functionality

Rémi Denis-Courmont remi at remlab.net
Mon Nov 28 18:03:35 CET 2016

Le maanantaina 28. marraskuuta 2016, 17.56.57 EET Filip Roséen a écrit :
> Hi Remi,
> On 2016-11-28 18:52, Rémi Denis-Courmont wrote:
> > Nack. Demuxer code has no business messing with input thread. It´s
> > even not the only use case for demux..
> The alternative would be to move the stream-creation to outside the
> relevant function, I have a patch for that, but it is more intrusive
> than what is addressed in this patch (which is why I decided to push
> this one instead of the other).
> I do however agree with you, and I have for a long time been feeling
> very anxious regarding the fact that we conditionally create the
> input-stream chain inside `src/input/demux.c`.

The demuxer shouldn´t even have a pointer to the input, and I plan to remove 
if/when we have proper demuxer controls for mouse (navigation) events.

Rémi Denis-Courmont

More information about the vlc-devel mailing list