[vlc-devel] [PATCH] video_out/mac: Enable bt2020 color space

[Felix Paul Kühne]

Hey Vittorio,

This patch needs a ifdef in case kCGColorSpaceITUR_2020 is not defined (as it was introduced in macOS 10.11 and we still want to support the 10.10 SDK) similar to what we do for other constants like in the VideoToolbox decoder.

Otherwise, LGTM and no idea why I didn’t do it like that in the first place.

Cheers,

Felix

> On 2 Oct 2016, at 03:45, Vittorio Giovara <vittorio.giovara at gmail.com> wrote:
> 
> ---
> Not sure if this was on purpose or a typo, sending just in case.
> Vittorio
> 
> modules/video_output/caopengllayer.m | 2 +-
> modules/video_output/macosx.m        | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/video_output/caopengllayer.m b/modules/video_output/caopengllayer.m
> index ab10594..c3f33e1 100644
> --- a/modules/video_output/caopengllayer.m
> +++ b/modules/video_output/caopengllayer.m
> @@ -214,7 +214,7 @@ static int Open (vlc_object_t *p_this)
>                     case COLOR_PRIMARIES_BT2020:
>                     {
>                         msg_Dbg(vd, "Using BT.2020 color space");
> -                        sys->cgColorSpace = CGColorSpaceCreateWithName(kCGColorSpaceITUR_709);
> +                        sys->cgColorSpace = CGColorSpaceCreateWithName(kCGColorSpaceITUR_2020);
>                         break;
>                     }
>                     case COLOR_PRIMARIES_DCI_P3:
> diff --git a/modules/video_output/macosx.m b/modules/video_output/macosx.m
> index 6c13eb6..e0d1860 100644
> --- a/modules/video_output/macosx.m
> +++ b/modules/video_output/macosx.m
> @@ -184,7 +184,7 @@ static int Open (vlc_object_t *this)
>                 case COLOR_PRIMARIES_BT2020:
>                 {
>                     msg_Dbg(vd, "Using BT.2020 color space");
> -                    sys->cgColorSpace = CGColorSpaceCreateWithName(kCGColorSpaceITUR_709);
> +                    sys->cgColorSpace = CGColorSpaceCreateWithName(kCGColorSpaceITUR_2020);
>                     break;
>                 }
>                 case COLOR_PRIMARIES_DCI_P3:
> -- 
> 2.10.0
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel