[vlc-devel] [PATCH 1/2] deinterlace: remove duplicated instruction in arm64 NEON merge asm

Janne Grunau janne-vlc at jannau.net
Thu Oct 13 01:03:18 CEST 2016


The duplicated instruction calculates wrong results for the
first 16 pixel of every 64 pixels for 8 bits per pixel formats.

Refs #17486
---
 modules/video_filter/deinterlace/merge_arm64.S | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/video_filter/deinterlace/merge_arm64.S b/modules/video_filter/deinterlace/merge_arm64.S
index ad898a3..827d6f5 100644
--- a/modules/video_filter/deinterlace/merge_arm64.S
+++ b/modules/video_filter/deinterlace/merge_arm64.S
@@ -43,7 +43,6 @@ merge8_arm64_neon:
 	uhadd		v0.16b, v0.16b, v4.16b
 	ld1		{v6.16b,v7.16b}, [x12], x10
 	subs		x5,  x5,  #64
-	uhadd		v0.16b, v0.16b, v4.16b
 	uhadd		v1.16b, v1.16b, v5.16b
 	uhadd		v2.16b, v2.16b, v6.16b
 	uhadd		v3.16b, v3.16b, v7.16b
-- 
2.10.1



More information about the vlc-devel mailing list