[vlc-devel] [PATCH 01/13] lib/media_discovery: narrower scope of iteration variable

Filip Roséen filip at atch.se
Thu Oct 13 13:28:02 CEST 2016


Hi Christoph,

I have been thinking about just sending a link to a repo having all
the patches, and then someone who is really bored could perhaps check
that repo, and merge what he/she feels appropriate.

Even though the above sounded like a good idea to me at first, it
might result in the patches just gathering dust in that external repo
(instead of my local machine).

On 2016-10-13 09:39, Christoph Miebach wrote:

> Hello!
> 
> I think this kind of patch is allowed to be pushed without another
> extra email in the future. There a 2 possible states:
> 
>  - we want the change introduced by the patch
>  - we don’t want the change
> 
> Since there were several of those patches here already, I guess we
> all agree on the first variant.
> 
> So, IMHO just go ahead an push patches like this without additional
> email.

Given that I do not have *commit-access*, my pathes goes through
`vlc-devel` for that reason alone.

I can however understand that it is somewhat annoying having 200+
patches all related to minor clean-ups flooding the subscribers of
`vlc-devel`; but currently I am not sure if there is an alternative to
the current workflow.

> 
> Regards
> 
> Christoph
>  
> > On 12 Oct 2016, at 20:08, Filip Roséen <filip at atch.se> wrote:
> > 
> > -    int i;
> > -
> 
> 
> > -    for( i = 0; all_keys[i]; i++ )
> > +    for( int i = 0; all_keys[i]; i++ )
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161013/c669660b/attachment.html>


More information about the vlc-devel mailing list