[vlc-devel] [PATCH 2/6] codec: use macros to avoid confusion between data[0] and data[3] types

[Rémi Denis-Courmont]

Le torstaina 20. lokakuuta 2016, 15.52.12 EEST Steve Lhomme a écrit :
> On Thu, Oct 20, 2016 at 3:40 PM, Rémi Denis-Courmont <remi at remlab.net> 
wrote:
> > Le torstaina 20. lokakuuta 2016, 15.26.09 EEST Steve Lhomme a écrit :
> >> having data[3] = data[0] doesn't help
> > 
> > It does because it matches the libavcodec documetation. This patch is
> > making things even more confusing.
> 
> I only found the AV_PIX_FMT_xxx_VLD that explains what data[3] should
> be and only the AV_PIX_FMT_VDPAU_xxx describe that data[0] should be a
> vdpau_render_state which we don't seem to use.
> 
> I trust that data[0] must not be NULL according to the VLC
> documentation but changing the type had no effect for me at all. It
> would be weird that libavcodec knows what a picture_t is anyway.
> 
> AV_FRAME_SURFACE() may be renamed to AV_FRAME_SURFACE_CTX() to avoid
> more confusion. But the change really helped me decipher what's going
> on in there.

Paint me unconvinced. Besides, it does not address my concerns.

-- 
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf