[vlc-devel] [PATCH 1/6] avcodec: remove unused parameter in va->release()

Rémi Denis-Courmont remi at remlab.net
Mon Oct 24 10:23:47 CEST 2016

Le torstaina 20. lokakuuta 2016, 15.57.55 EEST Steve Lhomme a écrit :
> I went the other way and got rid of picture_t. It simplifies the
> buffer release either by removing a picture_Release call (there's no
> picture_t involved at that level) or even get rid of va->release when
> it does nothing. Which was not possible when the va had to deal with a
> picture_t.

I don´t disagree with this specific patch (unlike the following one). Useless 
parameters can and should be removed. My point was that this is only the tip 
of the iceberg.

In the long run, vlc_va_t.extract() should be superseded by opaque-to-RAM 
video format conversion plugins, and then removed. In turn, that imples the 
removal of vlc_va_t.release() in favor or picture_Release() - since the 
conversion plugins would not have access to vlc_va_t.release().

Rémi Denis-Courmont
Nonsponsored VLC developer

More information about the vlc-devel mailing list