[vlc-devel] [sout developers] VLC streaming violation of MPEG-TS discontinuity flag

[Rémi Denis-Courmont]

Le tiistaina 25. lokakuuta 2016, 13.43.11 EEST Francois Cartegnie a écrit :
> Le 12/10/2015 à 17:03, Jean-Paul Saman a écrit :
> > It took a little longer, but here are patches:
> > 
> > The following logic has been used in the patches:
> > 
> > + decoders :
> >    - reset timeline on BLOCK_FLAG_DISCONTINUITY
> >    - flush on BLOCK_FLAG_CORRUPTED
> > 
> > + packetizers:
> >    - flush bytestream on  BLOCK_FLAG_DISCONTINUITY and
> >    BLOCK_FLAG_CORRUPTED
> > 
> > + ts-demux:
> >    - set BLOCK_FLAG_CORRUPTED on incomplete frame (might also happen on
> > 
> > seek)
> > 
> >    - set BLOCK_FLAG_DISCONTINUITY on seeking (time line discontinuity)
> >    - pass on ts-header discontinuity as BLOCK_FLAG_DISCONTINUITY
> 
> Hi,
> 
> Fixing the sout discontinuities issue and drawing up some conclusions,
> I realize we already talked about mostly the same required fixes.
> 
> Unsure why this discussion has stopped,
> but any reason those patches have never been committed/never made
> intentionally public ?

The patches were badly broken, causing a number of regressions.

And flushing on discontinuity or corruption seems like a cure worse than the 
disease.

-- 
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf