[vlc-devel] [sout developers] VLC streaming violation of MPEG-TS discontinuity flag

[Rémi Denis-Courmont]

Le tiistaina 25. lokakuuta 2016, 14.51.35 EEST Francois Cartegnie a écrit :
> Le 25/10/2016 à 14:28, Rémi Denis-Courmont a écrit :
> > Discontinuity due to seeking is not the same as discontinuity due to
> > silence in speech codec or due to packet loss. For instance, packetizers
> > obviously handle the former and the later very differently.
> 
> - Discontinuity on seek.
> I only see a flush requirement, which probably does not need to be done
> indirectly through blocks.

I suppose that I agree. Seek should not be handled through a block flag. The 
packetizer and decoder should be reset, by calling the flush callback, by 
destroying and recreating them, or whatever.

That´s not what the patch series did.

> - On silence and packet loss.
> Decoders should behave the same. Silence is more or less SPU.
> Output previous buffers, then use new timeline, tag first block output
> from the new timeline with discontinuity.

I suppose so, although I suspect that some decoders could do away with the 
timeline entirely, and just copy the PTS to the output timestamp.

-- 
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf