[vlc-devel] [PATCH] stream_filter: add ADF stream filter (Fixes #17501)
filip at atch.se
Tue Oct 25 17:31:10 CEST 2016
On 2016-10-25 17:18, Francois Cartegnie wrote:
> Le 25/10/2016 à 06:56, Tristan Matthews a écrit :
> > + /* Probe for XOR'd ID3 tag. */
> > + if( memcmp( peek, "\x6B\x66\x11", 3 ) )
> > + return VLC_EGENERIC;
> Being before any demuxer and packetizer,
> expect high rate of false positives.
- Why would this cause a *"high rate of false positives"?
It is equivalent to a *demuxer* probing for the same data, and as far
as I could see when I looked up the *magic-bytes* used, there is no
*file-format* that is publically documented that uses that marker.
I also ran `file` (the unix command) on a testfile, which came up
blank (not being able to identify the format used).
It is also not possible to have an implicitly used (ie. automatically
probed) *stream-filter* after a *packetizer* and/or *demuxer*.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the vlc-devel