[vlc-devel] [PATCH] stream_filter: add ADF stream filter (Fixes #17501)
Rémi Denis-Courmont
remi at remlab.net
Tue Oct 25 20:24:24 CEST 2016
Le tiistaina 25. lokakuuta 2016, 18.45.01 EEST Francois Cartegnie a écrit :
> Le 25/10/2016 à 18:25, Tristan Matthews a écrit :
> > I could reject urls not ending with .adf, not sure if that's
> > considered acceptable though.
>
> Probably better to put it as low priority one in es demux (and check
> extension), reusing/refactoring the code of the existing MPGA.
I very much disagree. This results in a duplicated code (and duplicated bugs),
and, in this case, we could check the extension if it turned really necessary.
Besides moving the probing to demuxers solves very much nothing by *default*.
It only fails in the corner case that you specified a custom demux, *and* you
use a stupid format *and* you have terrible luck.
Frankly, if you use a bad file format with completely random stuff in the
first few bytes, you are SOL. This is not just a VLC problem.
And there exists plenty of sane formats to carry raw audio or video that don´t
suffer that problem.
--
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf
More information about the vlc-devel
mailing list