[vlc-devel] [PATCH] lua/intf/cli: fix invalid concatenation of empty string

Filip Roséen filip at atch.se
Wed Oct 26 16:08:53 CEST 2016

Hi Pierre,

On 2016-10-26 15:48, Pierre Ynard wrote:

> > The entry still has the numeric identifier, which is unconditionally
> > displayed, so you would still be able to query information about the
> > entity (in case that is wanted).
> How do you query information about anything but the current item within
> the CLI?

I honestly thought that `cli.lua` had support for querying entity data
based on the numeric id, it was a "stupid" assumption based on the fact
that I really expected such information to be there.

 - Attached is a modified patch that simply prints "item.path" if the
   entity lacks a title.

 - I will probably write an enhancement for `cli.lua` later this
   evening so that information can be queried about arbitrary items
   without asking for playback, because I am honestly surprised that
   this is not present at the current time.

> > I do not understand what you mean by *"that possibly won't play
> > correctly"*, the "name" property of an item is not mandatory - and
> > will not aid when an item is actually scheduled to be played.
> The example in #17545 won't play, so you can't even play it to make it
> the current item, to then query it.

The snippet in `#17545` was written incorrectly, more specifically it
lacked the scheme for the *URI* supplied - I will update the ticket as
soon as possible. Thanks for letting me know about it.

Regarding *"you can't even play it to make it the current item"*,
that's in no way limited to the items that has no name (the same would
happen for media that as the relevant metadata, but fails to play).

Best Regards,\
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161026/965456c0/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lua-intf-cli-fix-invalid-concatenation-of-empty-stri.patch
Type: text/x-diff
Size: 1214 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20161026/965456c0/attachment.patch>

More information about the vlc-devel mailing list