[vlc-devel] [PATCH] mpg123: fix uninitialized read in DecodeBlock

[Jean-Baptiste Kempf]

LGTM

On Thu, 27 Oct 2016, at 09:49, Tristan Matthews wrote:
> Caught with valgrind.
> ---
>  modules/codec/mpg123.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/modules/codec/mpg123.c b/modules/codec/mpg123.c
> index 3e806ab..559bf57 100644
> --- a/modules/codec/mpg123.c
> +++ b/modules/codec/mpg123.c
> @@ -367,6 +367,8 @@ static int OpenDecoder( vlc_object_t *p_this )
>          return VLC_ENOMEM;
>  
>      p_sys->p_out = NULL;
> +    date_Set( &p_sys->end_date, VLC_TS_INVALID );
> +
>      /* Create our mpg123 handle */
>      if( ( p_sys->p_handle = mpg123_new( NULL, NULL ) ) == NULL )
>          goto error;
> -- 
> 2.9.3
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


-- 
  Jean-Baptiste Kempf
  jb at videolan.org