[vlc-devel] [PATCH] configure: Do not use libmicrodns on macOS

[Rémi Denis-Courmont]

Le perjantaina 28. lokakuuta 2016, 21.27.18 EEST Marvin Scholz a écrit :
> Due to macOS using Bonjour, libmicrodns can't bind to the requested
> port on macOS, so it does not make much sense to include it in builds
> for macOS.

I don´t see a compelling reason to special case this and forcefully disable 
the plugin though. If the library is useless to you, don´t include it in your 
build environment and voilà.

(Also, an application or application library should never assume that it can 
bind to a specific port. This looks like a bug in libmicrodns.)

> 
> See https://github.com/videolabs/libmicrodns/issues/9
> ---
>  configure.ac | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index a316e00..35e3d74 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -4020,7 +4020,9 @@ PKG_ENABLE_MODULES_VLC([UPNP], [upnp], [libupnp],
> [Intel UPNP SDK],[auto]) dnl
>  dnl mDNS using libmicrodns
>  dnl
> -PKG_ENABLE_MODULES_VLC([MICRODNS], [], [microdns], [mDNS services
> discovery], [auto]) +if test "${SYS}" != "darwin"; then
> +    PKG_ENABLE_MODULES_VLC([MICRODNS], [], [microdns], [mDNS services
> discovery], [auto]) +fi
> 
> 
>  EXTEND_HELP_STRING([Misc options:])


-- 
Rémi Denis-Courmont
Nonsponsored VLC developer
http://www.remlab.net/CV.pdf