[vlc-devel] [PATCH] modules: do not recurse into plugin directories

[Rémi Denis-Courmont]

Le maanantaina 31. lokakuuta 2016, 15.37.32 EET Felix Paul Kühne a écrit :
> >> On Thu, 27 Oct 2016, at 12:00, Rémi Denis-Courmont wrote:
> >>> This speeds up LibVLC initialization significantly.
> >>> (On my primary system, a reduction of about 60% in run time.)
> >> 
> >> What does it mean for us? That all the plugins should be in a single
> >> folder?
> > 
> > No, you can have as many base directories as you want, with as many
> > subdirectories as you want, as before.
> > 
> > But it means that plugins not in the cache won´t be loaded.
> 
> In other words, I need to force-update my cache after adding a plugin?

Yes. Now this patch is moot, but if you pass --no-plugins-scan, that is what 
will happen.

Scanning the plugins directories and subdirectories is currently the single 
largest bottleneck in libvlc_new(), if the plugins cache is valid. It dwarves 
everything else for plugins that are normally already in the cache anyway.

At least on my system (and it´s using an SSD), YMMV. In other words, as long 
as we keep this, we can´t speed libvlc_new() up in any meaningful way.

(If the plugins cache is stale or missing, most of the time is loading and 
linking the plugins.)

-- 
Rémi Denis-Courmont
http://www.remlab.net/