[vlc-devel] [PATCH] macosx: Fix runtime error on 10.7

Felix Paul K├╝hne fkuehne at videolan.org
Wed Sep 7 13:16:45 CEST 2016


Hey Marvin,

Looks good to me, please push :)

Best regards,

Felix

> On 07 Sep 2016, at 11:31, Marvin Scholz <epirat07 at gmail.com> wrote:
> 
> On 10.7 and below it's not allowed to have a weak
> reference to an NSWindow (and some other classes)
> ---
> modules/gui/macosx/VLCMainWindow.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/modules/gui/macosx/VLCMainWindow.h b/modules/gui/macosx/VLCMainWindow.h
> index 940b7d9..06fbc48 100644
> --- a/modules/gui/macosx/VLCMainWindow.h
> +++ b/modules/gui/macosx/VLCMainWindow.h
> @@ -73,7 +73,7 @@ typedef enum {
> @property (readwrite, weak) IBOutlet NSButton           *podcastRemoveButton;
> 
> // Podcast Subscribe Window outlets
> - at property (readwrite, weak) IBOutlet NSWindow           *podcastSubscribeWindow;
> + at property (readwrite)       IBOutlet NSWindow           *podcastSubscribeWindow;
> @property (readwrite, weak) IBOutlet NSTextField        *podcastSubscribeTitle;
> @property (readwrite, weak) IBOutlet NSTextField        *podcastSubscribeSubtitle;
> @property (readwrite, weak) IBOutlet NSTextField        *podcastSubscribeUrlField;
> @@ -81,7 +81,7 @@ typedef enum {
> @property (readwrite, weak) IBOutlet NSButton           *podcastSubscribeCancelButton;
> 
> // Podcast Unsubscribe Window outlets
> - at property (readwrite, weak) IBOutlet NSWindow           *podcastUnsubscribeWindow;
> + at property (readwrite)       IBOutlet NSWindow           *podcastUnsubscribeWindow;
> @property (readwrite, weak) IBOutlet NSTextField        *podcastUnsubscirbeTitle;
> @property (readwrite, weak) IBOutlet NSTextField        *podcastUnsubscribeSubtitle;
> @property (readwrite, weak) IBOutlet NSPopUpButton      *podcastUnsubscribePopUpButton;
> -- 
> 2.7.4 (Apple Git-66)
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list