[vlc-devel] [PATCH] rtp: link tests with SOCKET_LIBS

[Steve Lhomme]

After a clean build it fails again. Here's a log of the linking issue:

  CCLD     srtp-test-recv.exe
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtp_setkey':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:304:
undefined reference to `_imp__htonl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `rtp_crypt':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:400:
undefined reference to `_imp__htonl at 4'
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:401:
undefined reference to `_imp__htonl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `rtp_digest':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:444:
undefined reference to `_imp__htonl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtp_crypt':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:482:
undefined reference to `_imp__htons at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtp_send':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:594:
undefined reference to `_imp__htonl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtp_recv':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:658:
undefined reference to `_imp__ntohl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtcp_crypt':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:729:
undefined reference to `_imp__ntohl at 4'
./.libs/libvlc_srtp.a(libvlc_srtp_la-srtp.o): In function `srtcp_send':
C:\Users\robux\Documents\Programs\Videolabs\build\win32\modules/../../../work/extras/package/win32/../../../modules/access/rtp/srtp.c:793:
undefined reference to `_imp__htonl at 4'


The test .exe files link directly to the lib. For some reason
libvlc_srtp_la_LIBADD is not added to srtp_test_recv_LDADD so adding
$(SOCKET_LIBS) there has no effect.

On Wed, Sep 14, 2016 at 4:58 PM, Steve Lhomme <robux4 at gmail.com> wrote:
> Indeed it works without now. It must be a glitch in my build setup.
>
> DISCARD.
>
> On Wed, Sep 14, 2016 at 3:54 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> Le keskiviikkona 14. syyskuuta 2016, 15.49.15 EEST Steve Lhomme a écrit :
>>> ---
>>>  modules/access/rtp/Makefile.am | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/modules/access/rtp/Makefile.am b/modules/access/rtp/Makefile.am
>>> index 05c9aae..fa1bc67 100644
>>> --- a/modules/access/rtp/Makefile.am
>>> +++ b/modules/access/rtp/Makefile.am
>>> @@ -16,9 +16,9 @@ libvlc_srtp_la_CFLAGS = $(GCRYPT_CFLAGS)
>>>  libvlc_srtp_la_LDFLAGS = -static
>>>  libvlc_srtp_la_LIBADD = $(GCRYPT_LIBS) $(LIBPTHREAD)
>>>  srtp_test_recv_SOURCES = access/rtp/srtp-test-recv.c
>>> -srtp_test_recv_LDADD = libvlc_srtp.la
>>> +srtp_test_recv_LDADD = libvlc_srtp.la $(SOCKET_LIBS)
>>>  srtp_test_aes_SOURCES = access/rtp/srtp-test-aes.c
>>> -srtp_test_aes_LDADD = $(GCRYPT_LIBS)
>>> +srtp_test_aes_LDADD = $(GCRYPT_LIBS) $(SOCKET_LIBS)
>>>
>>>  librtp_plugin_la_DEPENDENCIES =
>>>  if HAVE_GCRYPT
>>
>> I can´t see any dependency on socket or NS libraries in those.
>>
>> --
>> Rémi Denis-Courmont
>> http://www.remlab.net/
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel