[vlc-devel] [vlc-commits] config-file: no need to alias fdatasync

[David Fuhrmann]

> Am 20.09.2016 um 21:40 schrieb Jean-Baptiste Kempf <git at videolan.org>:
> 
> vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Tue Sep 20 21:38:08 2016 +0200| [530d777f98bdce77360f01956529b06c9e6ce8d4] | committer: Jean-Baptiste Kempf
> 
> config-file: no need to alias fdatasync
> 
> It should be detected in configure
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=530d777f98bdce77360f01956529b06c9e6ce8d4
> ---
> 
> src/config/file.c | 4 ----
> 1 file changed, 4 deletions(-)
> 
> diff --git a/src/config/file.c b/src/config/file.c
> index 0a5a0be..3430ee8 100644
> --- a/src/config/file.c
> +++ b/src/config/file.c
> @@ -499,11 +499,7 @@ int config_SaveConfigFile (vlc_object_t *p_this)
>        fclose (file);
>        goto error;
>    }
> -#if defined(__APPLE__) || defined(__ANDROID__)
> -    fsync (fd); /* Flush from OS */
> -#else
>    fdatasync (fd); /* Flush from OS */
> -#endif

Hi,

This seems to break OS X compilation.
It looks that fdatasync is wrongly detected as present by configure, and thus the fsync replacement in configure does not work.

This seems to be a bug in OS X, see:
https://bugs.freedesktop.org/show_bug.cgi?id=74873
https://public.kitware.com/Bug/view.php?id=10044
https://www.monetdb.org/bugzilla/show_bug.cgi?id=2536

Unfortunately, we cannot fix OS X. Do you have any better idea than reverting that patch (the ifdef APPLE part)?

Best regards,
David