[vlc-devel] [PATCH 0/3] decoder: don't update format when creating a buffer

Thomas Guillem thomas at gllm.fr
Thu Sep 22 10:20:42 CEST 2016


Hello,

I propose to change the behavior of decoder_NewAudioBuffer(). This function
won't update the audio format anymore, the decoder module is now responsible
for updating the format.

In this set of patches, decoder_UpdateAudioFormat() is called in every modules
before decoder_NewAudioBuffer() to keep the previous behavior.

We'll now be able, for some modules, to call decoder_UpdateAudioFormat() in a
better place (like when we know the fmt_out is updated).

If you agree with that, I can do the same for VIDEO.

Best regards,
Thomas Guillem.

Thomas Guillem (3):
  decoder: audio: don't update format when creating a buffer
  decoder: prepare format in decoder_UpdateAudioFormat
  decoder: assert if aout format is not prepared

 modules/codec/adpcm.c        |  2 ++
 modules/codec/aes3.c         |  2 ++
 modules/codec/araw.c         |  2 ++
 modules/codec/dmo/dmo.c      |  6 ++++++
 modules/codec/faad.c         |  5 ++++-
 modules/codec/flac.c         |  3 +++
 modules/codec/fluidsynth.c   |  2 ++
 modules/codec/g711.c         |  5 +++++
 modules/codec/lpcm.c         |  2 ++
 modules/codec/mft.c          |  2 ++
 modules/codec/mpeg_audio.c   |  2 ++
 modules/codec/mpg123.c       |  2 ++
 modules/codec/omxil/omxil.c  |  2 ++
 modules/codec/opus.c         |  2 ++
 modules/codec/speex.c        |  9 +++++++--
 modules/codec/uleaddvaudio.c |  2 ++
 modules/codec/vorbis.c       |  1 +
 modules/codec/wmafixed/wma.c |  2 ++
 src/input/decoder.c          | 12 +++++-------
 19 files changed, 55 insertions(+), 10 deletions(-)

-- 
2.9.3



More information about the vlc-devel mailing list