[vlc-devel] [PATCH 4/8] input/decoder: fix leak if DecoderPlaySout fail

Filip Roséen filip at atch.se
Fri Sep 23 16:02:02 CEST 2016


Thanks to *tguillem* for letting me know that this commit message
looks rather weird. It should, of course, refer to a relevant
*ticket-id*.

The *"#FINISH"* is what I normally write whenever I do not know the
*ticket-id* yet. See the attached patch that includes a commit-message
that actually makes sense.

On 2016-09-23 15:43, Filip Roséen wrote:

> fixes #FINISH
> ---
>  src/input/decoder.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/input/decoder.c b/src/input/decoder.c
> index e894925..a736143 100644
> --- a/src/input/decoder.c
> +++ b/src/input/decoder.c
> @@ -838,6 +838,10 @@ static void DecoderProcessSout( decoder_t *p_dec, block_t *p_block )
>                  p_dec->b_error = true;
>  
>                  /* Cleanup */
> +
> +                if( p_block )
> +                    block_Release( p_block );
> +
>                  block_ChainRelease( p_next );
>                  return;
>              }
> -- 
> 2.10.0
> 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160923/cef993ce/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-input-decoder-fix-leak-if-DecoderPlaySout-fail.patch
Type: text/x-diff
Size: 796 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160923/cef993ce/attachment.patch>


More information about the vlc-devel mailing list