[vlc-devel] [vlc-commits] aout: always signal when the aout changed

[Rémi Denis-Courmont]

Le lundi 26 septembre 2016, 09:24:37 Thomas Guillem a écrit :
> On Sat, Sep 24, 2016, at 01:18, remi at remlab.net wrote:
> > Hello,
> > 
> > Le 22 sept. 2016 11:32, git at videolan.org a écrit :
> >  > vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Sep 22
> >  > 16:36:59 2016 +0200| [4bba1e84a13a8d340b8a06df155bec8034bcd012] |
> >  > committer: Thomas Guillem
> >  > 
> >  > aout: always signal when the aout changed
> >  > 
> >  > In a previous patch, we signaled that the aout changed when it was
> >  > restarted.
> > 
> > Because the decoder needs to handle it.
> > 
> > > We also need to signal that event when an aout module selects a
> > > device without
> > > 
> >  > requesting a restart.
> > 
> > No? There is nothing for the decoder to do there.
> 
> We may want to restart the decoder in order to try pass-through with the
> new selected audio device.
> (If the restarted decoder is the same, the aout won't be restarted since
> the audio fmt is the same.)

But the glitch will still be far worse, I suspect. And I wouldn't be surprised 
if it broke the decoder clock in subtle or not so subtle ways, leading e.g. to 
no audible sound until seek..

> I also thought about always restarting the aout/decoder after a
> device_select (and remove sink move in pulse aout) in order to simplify
> and have only one way to select a new device with all plugins. But this
> may be too overkill.

-- 
Rémi Denis-Courmont
http://www.remlab.net/