[vlc-devel] [PATCH] Windows: don't display a dialog when crash upload fails

[Filip Roséen]

Hi Steve,

On 2016-09-26 14:40, Steve Lhomme wrote:

> Similar philosophy as 45b0e1644d8f1812d4b6391a7cefedc9f4d44c6d
> ---

> -              MessageBox( NULL, L"There was an error while connecting to the Internet.\n"\
> -                                "Thanks a lot for the help anyway.",
> -                                L"Report sending failed", MB_OK);
> +              fprintf(stderr,"There was an error while connecting to the Internet.\n",
> +                      (unsigned long)GetLastError());

I am personally not a big fan of diagnostics that mention *"connecting
to the Internet"*, mostly because there might be an *"internet
connection"* (whatever that is) but other reasons for not being able
to establish a connection to the relevant party.

Examples:

  - If there is a firewall blocking connections to the relevant
    destination, how is this "not being able to connect to the
    Internet"?

  - If the FTP-server is down, it is certainly not a "connecting to
    the Internet" issue.

---------------------------------------------------------------------

Unused argument
---------------------------------------------------------------------

Given that the format-string does not include any place where
`(unsigned long)GetLastError())` is used, either the relevant
argument, or include it.

--------------------------------------------------------------------

Further thoughts
---------------------------------------------------------------------

I think we are going about this the wrong way, and that it certainly
make sense to invoke `MessageBox` with relevant contents if a
bug-report fails to upload (maybe even ask if the user would like to
save it somewhere for later access in that case).

In case the upload is successful (which the user certainly expects it
to be), I think we can ignore creating a `MessageBox` since a missing
one certainly implies that things went smoothly.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20160926/862cde16/attachment.html>