[vlc-devel] [vlc-commits] contrib: dca: Invoke autoreconf

[Steve Lhomme]

On Tue, Sep 27, 2016 at 12:48 PM, Sean McGovern <gseanmcg at gmail.com> wrote:
> Hi,
>
> On Sep 27, 2016 03:18, "Steve Lhomme" <robux4 at gmail.com> wrote:
>>
>> On Fri, Sep 23, 2016 at 4:39 PM, Hugo Beauzée-Luyssen <git at videolan.org>
>> wrote:
>> > vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Fri Sep
>> > 23 16:36:34 2016 +0200| [3ea47109501c05cab032065f06df455bf99d3be5] |
>> > committer: Hugo Beauzée-Luyssen
>> >
>> > contrib: dca: Invoke autoreconf
>> >
>> > The shipped aclocal.m4 doesn't play well when cross compiling for win32
>> > with a compiler that isn't gcc
>> >
>> >>
>> >> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3ea47109501c05cab032065f06df455bf99d3be5
>> > ---
>> >
>> >  contrib/src/dca/rules.mak | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/contrib/src/dca/rules.mak b/contrib/src/dca/rules.mak
>> > index cf427da..2b977a0 100644
>> > --- a/contrib/src/dca/rules.mak
>> > +++ b/contrib/src/dca/rules.mak
>> > @@ -25,6 +25,7 @@ libdca: libdca-$(DCA_VERSION).tar.bz2 .sum-dca
>> >         $(MOVE)
>> >
>> >  .dca: libdca
>> > +       $(RECONF)
>> >         cd $< && $(HOSTVARS) CFLAGS="$(CFLAGS) -std=gnu89" ./configure
>> > $(HOSTCONF)
>>
>> Maybe remove the "-std=gnu89" as well ? That doesn't sound too good
>> mixed with code that requires C99 and C++11.
>
> Ermmm, no. It won't build without that.

It builds with (a wrapper around) MS cl.exe v14.0. It doesn't seem to
use any particular extensions.

> This library is old and unmaintained -- perhaps it is time to remove it?
>
> -- Sean McG.
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>