[vlc-devel] [PATCH] es_out: fully refactor es_selection

Francois Cartegnie fcvlcdev at free.fr
Wed Sep 28 20:12:31 CEST 2016


Le 26/09/2016 à 19:02, Jean-Baptiste Kempf a écrit :
> On 26 Sep, Francois Cartegnie wrote :
>> also changes sub-language to "none", fixing the none/any logic.
> 
> Can we have a test on this thingie?

As for now, the libvlc-media- ES selection events are inconsistent.

They are proxying the var_Set callbacks on "*-es" variables,
but the es_out Auto selection uses var_Change, which will never trigger
any callback.

The only internal event on ES change is through "intf-event", which does
only tells one or more 'undefined' ES has changed, go figure.

As for now, consistency with UI is only done by polling the ES states on
intf-event.

One way to fix this is:
-> get rid of callbacks on "*-es" variables
-> add API to set es per category
-> create ES Added/Removed/Selected events and map them to libvlcmedia ones

Another issue is "*-es" vars being integer with 'choice'.
It cannot handle multiple ES selection. Neither current ES related
events or callbacks.

François


More information about the vlc-devel mailing list