[vlc-devel] [PATCH 0/3] subpictures outside the video area

Salah-Eddin Shaban salah at videolan.org
Wed Apr 5 10:24:11 CEST 2017


Hello,

I have pinged JB a couple of times for an update on these patches. He
eventually said he is too busy right now.

But I have noticed an issue here. Destination dimensions are set
correctly only for subpictures we render ourselves (OSD, SubRip,
MicroDVD...). For others like SSA something similar has to be done.

But before I give this any more time I need to check with you guys.

Shall I attempt to fix this issue, or is there something inherently
wrong with these patches that has prevented them from being merged?

On Fri, Mar 3, 2017 at 7:05 PM, Salah-Eddin Shaban <salah at videolan.org> wrote:
>
> Salah-Eddin Shaban (3):
>   vout: support rendering subpictures in display dimensions
>   direct3d9: render subpictures in display dimensions
>   Subtitles: fix misplaced subs on video resize
>
>  include/vlc_subpicture.h               |  8 ++++++++
>  include/vlc_vout_display.h             |  1 +
>  modules/video_output/win32/common.c    | 14 +++++++++++++-
>  modules/video_output/win32/direct3d9.c | 20 ++++++++++++--------
>  src/misc/subpicture.c                  |  6 ++++++
>  src/video_output/video_output.c        |  9 +++++++++
>  src/video_output/vout_subpictures.c    | 10 ++++------
>  7 files changed, 53 insertions(+), 15 deletions(-)
>
> --
> 2.10.2
>


More information about the vlc-devel mailing list