[vlc-devel] [PATCH] vout_intf: remove dead code

[Steve Lhomme]

On Tue, Apr 4, 2017 at 3:12 PM, Steve Lhomme <robux4 at videolabs.io> wrote:
> Passing 0:0 as the crop ratio doesn't change the displayed ratio. It is
> forwarded as a call to vout_SetDisplayCrop() with num/den to 0/0 which is
> rejected.

This may be wrong after all. In vout_SetDisplayCrop() [1] if the
previous crop dimensions were not 0,0,0,0 it would reset them in that
case.

So forget this patch.

[1] http://git.videolan.org/?p=vlc.git;a=blob;f=src/video_output/display.c;h=77b4ef76d47e4cac430784c02467ef383e1ea1e2;hb=HEAD#l1186

> ---
>  src/video_output/vout_intf.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/video_output/vout_intf.c b/src/video_output/vout_intf.c
> index b494908bea..247c104196 100644
> --- a/src/video_output/vout_intf.c
> +++ b/src/video_output/vout_intf.c
> @@ -459,8 +459,6 @@ static int CropCallback( vlc_object_t *object, char const *cmd,
>      } else if (sscanf(newval.psz_string, "%u+%u+%u+%u",
>                      &left, &top, &right, &bottom) == 4) {
>          vout_ControlChangeCropBorder(vout, left, top, right, bottom);
> -    } else if (*newval.psz_string == '\0') {
> -        vout_ControlChangeCropRatio(vout, 0, 0);
>      } else {
>          msg_Err(object, "Unknown crop format (%s)", newval.psz_string);
>      }
> --
> 2.11.1
>