[vlc-devel] [vlc-commits] bin: use a full path to build plugins.dat

[David Fuhrmann]

> Am 12.04.2017 um 10:37 schrieb Steve Lhomme <git at videolan.org>:
> 
> vlc | branch: master | Steve Lhomme <robUx4 at videolabs.io> | Mon Apr 10 08:20:54 2017 +0200| [2c799b6fd77c1a37ae98d93e7449c7d8260febf7] | committer: Jean-Baptiste Kempf
> 
> bin: use a full path to build plugins.dat
> 
> This needed on Windows as LoadLibraryEx doesn't like relative pathes and thus
> building on Windows doesn't go to the end.
> 
> The resulting pathes in plugins.dat are still relative and so are the ones
> resulting from `make package-win-common` that can be distributed.
> 
> Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2c799b6fd77c1a37ae98d93e7449c7d8260febf7
> ---
> 
> bin/Makefile.am | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bin/Makefile.am b/bin/Makefile.am
> index c6ad2d7e0a..8f14a43d91 100644
> --- a/bin/Makefile.am
> +++ b/bin/Makefile.am
> @@ -116,7 +116,7 @@ endif
> ../modules/plugins.dat: vlc-cache-gen$(EXEEXT)
> 	$(AM_V_at)rm -f ../modules/plugins.dat
> 	$(AM_V_GEN)if test "$(build)" = "$(host)"; then \
> -		./vlc-cache-gen$(EXEEXT) ../modules ; \
> +		./vlc-cache-gen$(EXEEXT) `realpath ../modules` ; \
> 	else \
> 		echo "Cross-compilation: cache generation skipped!" ; \
> 	fi

Hi,

Looks like realpath is not available on OS X:

  GEN      ../modules/plugins.dat
/bin/sh: realpath: command not found

It does not generate a build error, though, as cache-gen seems to be simply called with an empty path instead.

As we currently call vlc-cache-gen again for VLC.app during OS X compilation, this is not a big problem, but I just want to make you aware.

BR. David 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20170414/d46f54e8/attachment.html>