[vlc-devel] [PATCH] vout: add derived chroma support

Rémi Denis-Courmont remi at remlab.net
Thu Apr 20 16:59:59 CEST 2017


On April 20, 2017 3:13:00 PM GMT+03:00, Thomas Guillem <thomas at gllm.fr> wrote:
>I think we need to rethink this method for VLC 4.0, but it's a good
>start for VLC 3.0 since this change is not too intrusive. Maybe we can
>remove the i_derive_chroma from the vlc_es.h and derive by default to
>I420.
>
>On Wed, Apr 19, 2017, at 13:26, Thomas Guillem wrote:
>> 
>> 
>> On Tue, Apr 18, 2017, at 20:07, Rémi Denis-Courmont wrote:
>> > Le tiistaina 18. huhtikuuta 2017, 15.02.13 EEST Thomas Guillem a
>écrit :
>> > > Hardware decoders that output opaque pictures can now specify a
>chroma that
>> > > could by used by CPU video filters. If no opaque video filters
>are found
>> > > (like vdpau interlace/adjust/sharpen), two video converter
>modules will be
>> > > inserted in the filter chain. One opaque to derived converter
>will be
>> > > inserted when first needed, and a derived to opaque converter
>will be
>> > > inserted at the end.
>> > 
>> > This looks totally redundant since video filters can already steer
>video 
>> > conversion.
>> 
>> I really don't see how you can do that.
>> 
>> > 
>> > No thanks.
>> > 
>> > -- 
>> > 雷米‧德尼-库尔蒙
>> > https://www.remlab.net/
>> > 
>> > _______________________________________________
>> > vlc-devel mailing list
>> > To unsubscribe or modify your subscription options:
>> > https://mailman.videolan.org/listinfo/vlc-devel
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

I think the current code is both cleaner and more flexible than this and we should keep it as it is in both 3.0 and 4.0.
-- 
Rémi Denis-Courmont


More information about the vlc-devel mailing list