[vlc-devel] [PATCH] video_filter-sharpen: change unsupported chroma msg_Err to msg_Dbg

Thomas Guillem thomas at gllm.fr
Thu Apr 20 17:05:00 CEST 2017



On Thu, Apr 20, 2017, at 17:00, Rémi Denis-Courmont wrote:
> On April 20, 2017 4:41:25 PM GMT+03:00, Victorien Le Couviour--Tuffet
> <victorien.lecouviour.tuffet at gmail.com> wrote:
> >---
> > modules/video_filter/sharpen.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/modules/video_filter/sharpen.c
> >b/modules/video_filter/sharpen.c
> >index 19f74b8bad..f3c62cb913 100644
> >--- a/modules/video_filter/sharpen.c
> >+++ b/modules/video_filter/sharpen.c
> >@@ -109,7 +109,7 @@ static int Create( vlc_object_t *p_this )
> >         (p_chroma->pixel_size != 1 &&
> >          p_filter->fmt_in.video.i_chroma != VLC_CODEC_I420_10L &&
> >          p_filter->fmt_in.video.i_chroma != VLC_CODEC_I420_10B)) {
> >-        msg_Err( p_filter, "Unsupported chroma (%4.4s)",
> >(char*)&fourcc );
> >+        msg_Dbg( p_filter, "Unsupported chroma (%4.4s)",
> >(char*)&fourcc );
> >         return VLC_EGENERIC;
> >     }
> > 
> >-- 
> >2.12.0
> >
> >_______________________________________________
> >vlc-devel mailing list
> >To unsubscribe or modify your subscription options:
> >https://mailman.videolan.org/listinfo/vlc-devel
> 
> How is that not an error?

It's a probing error. We should not print them as error since there may
be more than one sharpen modules (like the vdpau one).

> -- 
> Rémi Denis-Courmont
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list