[vlc-devel] [vlc-commits] vout: opengl: fix green lines with PBO

[Steve Lhomme]

On Fri, Apr 21, 2017 at 6:22 PM, Thomas Guillem <git at videolan.org> wrote:
> vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Apr 21 18:21:47 2017 +0200| [a16e72792aab02922a4a4b50dd711bf8a09ba13a] | committer: Thomas Guillem
>
> vout: opengl: fix green lines with PBO
>
> Fixes #18213
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a16e72792aab02922a4a4b50dd711bf8a09ba13a
> ---
>
>  modules/video_output/opengl/converters.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/modules/video_output/opengl/converters.c b/modules/video_output/opengl/converters.c
> index a15dcfe9dd..000358595e 100644
> --- a/modules/video_output/opengl/converters.c
> +++ b/modules/video_output/opengl/converters.c
> @@ -622,7 +622,7 @@ tc_pbo_update(const opengl_tex_converter_t *tc, GLuint *textures,
>
>      for (int i = 0; i < pic->i_planes; i++)
>      {
> -        GLsizeiptr size = pic->p[i].i_visible_lines * pic->p[i].i_visible_pitch;
> +        GLsizeiptr size = pic->p[i].i_lines * pic->p[i].i_pitch;

You probably only need the visible lines. (Which may or may not
contain the x/y_offset depending on the interpretation of the code).

>          const GLvoid *data = pic->p[i].p_pixels;
>          tc->api->BindBuffer(GL_PIXEL_UNPACK_BUFFER,
>                              display_pic->p_sys->buffers[i]);
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits