[vlc-devel] [PATCH 1/2] vout: remove xmalloc

[Rémi Denis-Courmont]

Le tiistaina 25. huhtikuuta 2017, 13.38.09 EEST Victorien Le Couviour--Tuffet 
a écrit :
> ---
>  src/video_output/video_output.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/src/video_output/video_output.c
> b/src/video_output/video_output.c index 8b48a1cc8a..6ea72ba468 100644
> --- a/src/video_output/video_output.c
> +++ b/src/video_output/video_output.c
> @@ -714,7 +714,10 @@ static void ThreadChangeFilters(vout_thread_t *vout,
>          char *next = config_ChainCreate(&name, &cfg, current);
> 
>          if (name && *name) {
> -            vout_filter_t *e = xmalloc(sizeof(*e));
> +            vout_filter_t *e;
> +
> +            if (!(e = malloc(sizeof(*e))))
> +                return ;
>              e->name = name;
>              e->cfg  = cfg;
>              if (!strcmp(e->name, "deinterlace") ||

We don´t use assignment as expression when avoidable. And this seems to leak.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/