[vlc-devel] [PATCH 1/3] splitter: force splitters to sw chroma

[Rémi Denis-Courmont]

Le keskiviikkona 2. elokuuta 2017, 16.37.12 EEST Victorien Le Couviour--Tuffet 
a écrit :
> Fixes #18537.
> ---
>  src/misc/filter.c          |  4 ++++
>  src/video_output/display.c | 14 ++++++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/src/misc/filter.c b/src/misc/filter.c
> index 071e374ba4..7596f8734f 100644
> --- a/src/misc/filter.c
> +++ b/src/misc/filter.c
> @@ -190,6 +190,10 @@ video_splitter_t *video_splitter_New( vlc_object_t
> *p_this, return NULL;
> 
>      video_format_Copy( &p_splitter->fmt, p_fmt );
> +    vlc_chroma_description_t const *p_chroma =
> +        vlc_fourcc_GetChromaDescription(p_splitter->fmt.i_chroma);
> +    if (!p_chroma || !p_chroma->plane_count)
> +        p_splitter->fmt.i_chroma = VLC_CODEC_I420;

Nack. There are no reasons why a specific splitter couldn´t support a hardware 
format. And besides, the fallback to the _correct_ software chroma is already 
done by the decoder code, which is far better than hard-coded I420.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/