[vlc-devel] [PATCH 3/4] display: no need to pass the video_format_t for CROP/ASPECT_RATIO changes

Rémi Denis-Courmont remi at remlab.net
Wed Aug 2 17:40:58 CEST 2017

Le keskiviikkona 2. elokuuta 2017, 17.32.25 EEST Steve Lhomme a écrit :
> IMO it's important only if some modules wanted to know the previous
> value before making the change. If not (which is the case in all
> modules) then they don't care how they receive the data and if they
> can read the previous value.

You are assuming that either the change will be accepted, or the video output 
display does not care at all about crop and A/R. If so, then it makes sense to 
ignore failure. (I doubt that it really works anyway.)

> If they refuse they know nothing changed
> (or not) and they don't have to care how the core recovers from that,

I don´t see what would warrant that assumption in general. They´d have to copy 
the old source format.

> just like before.

I cannot agree. If we offer the possibility to reject the change, then we must 
provide the current value as a matter of principles. That´s most probably why 
Laurent designed the semantics as they currently are.

Otherwise we just assume the changes are always accepted.


More information about the vlc-devel mailing list