[vlc-devel] [PATCH 1/4] display: no need for a local video_format_t with VOUT_DISPLAY_CHANGE_SOURCE_ASPECT

[Steve Lhomme]

On Wed, Aug 2, 2017 at 5:36 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> Le keskiviikkona 2. elokuuta 2017, 17.23.47 EEST Steve Lhomme a écrit :
>> On Wed, Aug 2, 2017 at 4:33 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> > Le keskiviikkona 2. elokuuta 2017, 9.33.35 EEST Steve Lhomme a écrit :
>> >> Receivers don't check the difference with the original value, they just
>> >> apply the new value.
>> >
>> > Did you check if any video output uses vd->source on another thread?
>>
>> I can't tell for other calls. But in the CROP and ASPECT_RATIO one
>> vd->source is already modified during/after the event is called. So if
>> it's broken, it was broken before.
>
> Chage after is not the same as change before. You can sync the first one, you
> cannot sync the second one as it would break causality.

Sync between what the core expect and the vout does is still
respected. We could document that the new value is passed via
vd->source and reverted if the vout refuses the change. But I don't
think the patch breaks anything.

> --
> 雷米‧德尼-库尔蒙
> https://www.remlab.net/
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel