[vlc-devel] [PATCH] audio output: Allow i_physical_channels to be unset when using pass through

Hugo Beauzée-Luyssen hugo at beauzee.fr
Thu Aug 3 12:20:02 CEST 2017


On Wed, Aug 2, 2017, at 07:15 PM, Rémi Denis-Courmont wrote:
> Le tiistaina 1. elokuuta 2017, 14.08.24 EEST Hugo Beauzée-Luyssen a écrit
> :
> > Fix #18614
> 
> Don´t we still have have filters or output assuming that i_channels is
> set, or 
> is non-zero?
> 

This is about i_physical_channels, there is no problem with i_channels
as far as I can see.

Also, fitlers shouldn't be concern for pass through, and I'd argue that
an output that doesn't handle an unset i_physical_channels should be
fixed.

-- 
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr


More information about the vlc-devel mailing list