[vlc-devel] [PATCH 08/18] splitter: propagate fullscreen request

[Rémi Denis-Courmont]

Le perjantaina 4. elokuuta 2017, 19.41.02 EEST Victorien Le Couviour--Tuffet a 
écrit :
> ---
>  src/video_output/display.c | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/src/video_output/display.c b/src/video_output/display.c
> index d2daf8ba0d..d6718578fc 100644
> --- a/src/video_output/display.c
> +++ b/src/video_output/display.c
> @@ -1464,8 +1464,18 @@ static void SplitterDisplay(vout_display_t *vd,
>  }
>  static int SplitterControl(vout_display_t *vd, int query, va_list args)
>  {
> -    (void)vd; (void)query; (void)args;
> -    return VLC_EGENERIC;
> +    for (int i = 0; i < vd->sys->count; ++i)
> +        if (query == VOUT_DISPLAY_CHANGE_FULLSCREEN)
> +        {
> +            va_list tmp_args;
> +            va_copy(tmp_args, args);
> +            int ret = vd->sys->display[i]->control(vd->sys->display[i],
> +                                                   query, tmp_args);
> +            va_end(tmp_args);
> +            if (ret)
> +                return ret;
> +        }
> +    return VLC_SUCCESS;
>  }
>  static void SplitterManage(vout_display_t *vd)
>  {

And then what? You get multiple window in fullscreen? This looks like a 
solution worse than the bug.

-- 
雷米‧德尼-库尔蒙
https://www.remlab.net/